Skip to content
This repository was archived by the owner on Oct 20, 2020. It is now read-only.

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2020

Bumps rubocop-rails from 2.7.1 to 2.8.1.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.8.1

Bug fixes

  • #345: Fix error of Rails/AfterCommitOverride on after_commit with a lambda. (@pocke)
  • #349: Fix errors of Rails/UniqueValidationWithoutIndex. (@Tietew)
  • #338: Fix a false positive for Rails/IndexBy and Rails/IndexWith when the each_with_object hash is used in the transformed key or value. (@eugeneius)
  • #351: Add <> operator to Rails/WhereNot cop. (@Tietew)
  • #352: Do not register offense if given a splatted hash. (@dvandersluis)
  • #346: Fix a false positive for Rails/DynamicFindBy when any of the arguments are splat argument. (@koic)
  • #357: Fix a false positive for Rails/ReversibleMigration when keyword arguments of change_column_default are in the order of to, from. (@koic)

RuboCop Rails 2.8.0

New features

  • #291: Add new Rails/SquishedSQLHeredocs cop. (@mobilutz)
  • #52: Add new Rails/AfterCommitOverride cop. (@fatkodima)
  • #323: Add new Rails/OrderById cop. (@fatkodima)
  • #274: Add new Rails/WhereNot cop. (@fatkodima)
  • #311: Make Rails/HelperInstanceVariable aware of memoization. (@koic)
  • #332: Fix Rails/ReflectionClassName cop false negative when relation had a scope parameter. (@bubaflub)

Bug fixes

  • #315: Allow to use frozen scope for Rails/UniqueValidationWithoutIndex. (@krim)
  • #313: Fix Rails/ActiveRecordCallbacksOrder to preserve the original callback execution order. (@eugeneius)
  • #319: Fix a false positive for Rails/Inquiry when #inquiry's receiver is a variable. (@koic)
  • #327: Fix Rails/ContentTag autocorrect to handle html5 tag names with hyphens. (@jaredmoody)

Changes

  • #312: Mark Rails/MailerName as unsafe for auto-correct. (@eugeneius)
  • #294: Update Rails/ReversibleMigration to register offenses for remove_columns and remove_index. ([@philcoggins][])
  • #310: Add EnforcedStyle to Rails/PluckInWhere. By default, it does not register an offense if pluck method's receiver is a variable. (@koic)
  • #320: Mark Rails/UniqBeforePluck as unsafe auto-correction. ([@kunitoo][])
  • #324: Make Rails/IndexBy and Rails/IndexWith aware of to_h with block. (@eugeneius)
  • #341: Make Rails/WhereExists configurable to allow where(...).exists? to be the prefered style. (@dvandersluis)
Changelog

Sourced from rubocop-rails's changelog.

2.8.1 (2020-09-16)

Bug fixes

  • #345: Fix error of Rails/AfterCommitOverride on after_commit with a lambda. ([@pocke][])
  • #349: Fix errors of Rails/UniqueValidationWithoutIndex. ([@Tietew][])
  • #338: Fix a false positive for Rails/IndexBy and Rails/IndexWith when the each_with_object hash is used in the transformed key or value. ([@eugeneius][])
  • #351: Add <> operator to Rails/WhereNot cop. ([@Tietew][])
  • #352: Do not register offense if given a splatted hash. ([@dvandersluis][])
  • #346: Fix a false positive for Rails/DynamicFindBy when any of the arguments are splat argument. ([@koic][])
  • #357: Fix a false positive for Rails/ReversibleMigration when keyword arguments of change_column_default are in the order of to, from. ([@koic][])

2.8.0 (2020-09-04)

New features

  • #291: Add new Rails/SquishedSQLHeredocs cop. ([@mobilutz][])
  • #52: Add new Rails/AfterCommitOverride cop. ([@fatkodima][])
  • #323: Add new Rails/OrderById cop. ([@fatkodima][])
  • #274: Add new Rails/WhereNot cop. ([@fatkodima][])
  • #311: Make Rails/HelperInstanceVariable aware of memoization. ([@koic][])
  • #332: Fix Rails/ReflectionClassName cop false negative when relation had a scope parameter. ([@bubaflub][])

Bug fixes

  • #315: Allow to use frozen scope for Rails/UniqueValidationWithoutIndex. ([@krim][])
  • #313: Fix Rails/ActiveRecordCallbacksOrder to preserve the original callback execution order. ([@eugeneius][])
  • #319: Fix a false positive for Rails/Inquiry when #inquiry's receiver is a variable. ([@koic][])
  • #327: Fix Rails/ContentTag autocorrect to handle html5 tag names with hyphens. ([@jaredmoody][])

Changes

  • #312: Mark Rails/MailerName as unsafe for auto-correct. ([@eugeneius][])
  • #294: Update Rails/ReversibleMigration to register offenses for remove_columns and remove_index. ([@philcoggins][])
  • #310: Add EnforcedStyle to Rails/PluckInWhere. By default, it does not register an offense if pluck method's receiver is a variable. ([@koic][])
  • #320: Mark Rails/UniqBeforePluck as unsafe auto-correction. ([@kunitoo][])
  • #324: Make Rails/IndexBy and Rails/IndexWith aware of to_h with block. ([@eugeneius][])
  • #341: Make Rails/WhereExists configurable to allow where(...).exists? to be the prefered style. ([@dvandersluis][])
Commits
  • 2563954 Cut 2.8.1
  • 92c6828 Merge pull request #358 from koic/fix_false_positive_for_rails_reversible_mig...
  • 99515d0 [Fix #357] Fix a false positive for Rails/ReversibleMigration
  • 3ec7cda Merge pull request #346 from koic/fix_false_positive_for_dynamic_find_by
  • 01036ab Fix a false positive for Rails/DynamicFindBy
  • 13a0fbe Merge pull request #355 from koic/suppress_rubocop_offense
  • c9af0b5 Suppress RuboCop's offense
  • c2d3ade Merge pull request #354 from dvandersluis/fix-http-positional-kwspalt
  • 68e27a9 [Fix #352] Do not register an offense for Rails/HttpPositionalArguments whe...
  • 119bbaa Merge pull request #351 from Tietew/add_stdneq_wherenot
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant