Repository navigation
feat: optional secrets preset and snapshot-bound review gates - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
skillgate init --preset no-secrets, an optional TruffleHog credential gate with a local infrastructure-name denylist, and an optional snapshot-bound OCR/delegated-review report gate. TruffleHog and OCR stay external; scanner output is redacted, failures block, and these gates always re-evaluate even with--cache. Prepares v0.12.0 metadata and documentation.The delegated OCR thin slice on real PR #39 reproduced an invalid-policy bypass: opencode allowed a non-shell publish tool when it could not load the policy. The plugin now blocks unknown/MCP tools in that case while preserving built-in repair tools. The historical implementation allows the fixture; the fixed implementation blocks it.
Review reports are explicitly trusted reviewer attestations, not independent proofs that review ran. They must be complete, have no findings/warnings, and match policy, working files, and staged blob IDs. Verified-only credential detection also depends on provider reachability; static pattern gates remain useful for unsupported/unverifiable secrets.
Validation: