Repository navigation
docs(schema): a text-range-doubled lint hit on an ordinary draft is not damage - #88
Merged
Merged
Conversation
…ot damage Every pre-0.19.1 add-text wrote a doubled full-span range, and a full-span range clamps back to the end of the text, so most drafts carrying the defect rendered correctly all along. The rule therefore fires on plain caption work, not only on karaoke or keyword-highlight drafts, and a hit reads as 'written by an older version' rather than as a visible bug. Reported from the field on #85 after verifying 0.19.1 against CapCut 9.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents something that came out of the #85 field verification and wasn't written down anywhere.
Every pre-0.19.1
add-textwrote a doubled full-span range, and a full-span range clamps back to the end of the text when CapCut opens the draft. So the overwhelming majority of drafts carrying the defect rendered correctly the whole time — which is both why it survived twenty-odd releases and whylintnow fires on ordinary caption work, not only on karaoke or keyword-highlight drafts.Without that stated, a
text-range-doubledhit reads as damage. It usually isn't. The note in02-materials.mdsays so plainly, and draws the line: more than one range means a real visible bug, a lone full-span range means "written by an older version".--fixis correct in both cases — on the harmless kind it's a tidy-up, and it's safe to run either way because the doubled form is identifiable with certainty rather than inferred.Docs only — no source, no rule behaviour, no message text changed. 700/700 tests pass,
biome checkclean.