Get wf to accept unions for Fulminate #311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok so I think the sensible thing to do would be to have it be so that the diffed lines are guarded by whether or not it's in Fulminate mode, because silently accepting but not supporting unions in proof mode is a bad user experience. |
Agreed |
dc-mak
force-pushed
the
wf-pass-unions
branch
2 times, most recently
from
64a9ba1 to
cb20c3f
Compare
dc-mak
changed the title
dc-mak
force-pushed
the
wf-pass-unions
branch
from
cb20c3f to
fe8e091
Compare
|
This branch has been updated with pqwy@4033bee by @cp526. A more complete branch is now at https://github.com/pqwy/cn/tree/wf-pass-unions-plus . |
|
@dc-mak Could you rebase this onto |
This will allow sizeof(union tag) to work in the pipeline.
Not inlining labels means that some label arguments need to inferred rather than checked. This includes the UB for reaching the end of a function which returns a value without having a value to return. In this case, I just synthesise a Unit type as a dummy if we're in executable spec mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.