added new config setting, added language strings, changed lib.php to …#40
Open
spinozarabel wants to merge 3 commits intoremotelearner:MOODLE_38_STABLEfrom
Open
added new config setting, added language strings, changed lib.php to …#40spinozarabel wants to merge 3 commits intoremotelearner:MOODLE_38_STABLEfrom
spinozarabel wants to merge 3 commits intoremotelearner:MOODLE_38_STABLEfrom
Conversation
…include hidden courses based on setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…include hidden courses based on setting.
The MOODLE_38_STABLE branch only looks at courses that are set to be visible.
In our institution, to prevent children from being exposed to courses that they are not enrolled in, all courses are set to be hidden.
The existing version of the plugin therefore misses all of the relevant courses and shows nothing left to be graded even when ungraded items are present in these hidden courses.
In my fork I created a new admin setting that includes hidden courses, defaulting to 0 which falls back to performance of old.
When admin sets the setting by checking the box, then a small code change in the lib.php where courses are searched for now will include hidden courses also.