Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 0.47 Breaking Change with createJSModules Override #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for 0.47 Breaking Change with createJSModules Override #34

wants to merge 1 commit into from

Conversation

JPig
Copy link

@JPig JPig commented Aug 5, 2017

Fix for a breaking change made in react native 0.47 "Remove unused createJSModules calls"

@borisyankov borisyankov mentioned this pull request Aug 6, 2017
Closed
@borisyankov
Copy link

@fov42550564 Please merge this and publish?

@mkozhukharenko
Copy link

+1

@Chiamaka
Copy link

Please has this been merged? I'm having issues with this and the change doesn't reflect in the code

@JPig
Copy link
Author

JPig commented Sep 13, 2017

It hasn't been merged yet :(

@tony1223
Copy link

vote for this. we need this. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Satya5614 Satya5614 Satya5614 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JPig @borisyankov @mkozhukharenko @Chiamaka @tony1223 @Satya5614