chore: release v1.5.2 #7
Conversation
Release 1.5.2 with the addition of the compression middleware and updated package dependencies. Key changes include: - Added 'compression' package to improve response compression in the application. - Updated version in package.json to 1.5.2. - Enhanced start message to clarify internal ports used.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This release (v1.5.2) adds compression middleware and updates internal port display in startup messages.
- Added compression middleware in
src/main.tsbut missing implementation for internal app instance - Fixed hardcoded ports (61000, internalPort, 61002) in
src/common/utils/get-start-message.tsstartup display - Incorrect error constant in
src/modules/stats/stats.service.ts(FAILED_TO_GET_INBOUNDS_STATSvsFAILED_TO_GET_OUTBOUNDS_STATS) - Leftover commented demo code in
getUsersStatsmethod should be removed - Inconsistent error logging patterns across
stats.service.tserror handlers
4 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
| [ | ||
| ['Docs → https://remna.st\nCommunity → https://t.me/remnawave'], | ||
| [`API Port: ${appPort}\nInternal Port: ${internalPort}`], | ||
| [`API Port: ${appPort}\nInternal Ports: 61000, ${internalPort}, 61002`], |
There was a problem hiding this comment.
style: Hardcoding port numbers (61000, 61002) in the message could cause confusion if actual ports change. Consider using constants or configuration values instead.
| }), | ||
| }); | ||
|
|
||
| app.use(json({ limit: '1000mb' })); |
There was a problem hiding this comment.
style: 1000mb limit may be excessive and could expose the server to DoS attacks. Consider a lower limit based on actual requirements
| // const demoRes = Array.from({ length: 160_000 }, (_, i) => ({ | ||
| // username: String(i + 1), | ||
| // uplink: Math.floor(Math.random() * (107374182400 - 10485760) + 10485760), // Random between 10MB and 100GB | ||
| // downlink: Math.floor(Math.random() * (107374182400 - 10485760) + 10485760), // Random between 10MB and 100GB | ||
| // })); | ||
|
|
||
| // return { | ||
| // isOk: true, | ||
| // response: new GetUsersStatsResponseModel(demoRes), | ||
| // }; |
There was a problem hiding this comment.
style: Remove commented-out demo code before merging to main. If needed for testing, move to a separate test file.
| "@remnawave/supervisord-nestjs": "0.1.1", | ||
| "@remnawave/xtls-sdk": "0.3.0", | ||
| "@remnawave/xtls-sdk-nestjs": "0.2.2", | ||
| "compression": "^1.8.0", |
There was a problem hiding this comment.
style: consider pinning compression version to exact number (1.8.0) for better dependency predictability, matching style of other core dependencies
| "devDependencies": { | ||
| "@nestjs/cli": "11.0.5", | ||
| "@nestjs/schematics": "11.0.2", | ||
| "@types/compression": "^1.8.0", |
There was a problem hiding this comment.
style: consider pinning @types/compression version to match compression version exactly
| "compression": "^1.8.0", | ||
| "enhanced-ms": "^4.1.0", | ||
| "helmet": "^8.1.0", | ||
| "husky": "9.1.7", |
There was a problem hiding this comment.
logic: husky should be in devDependencies since it's only used during development
| "husky": "9.1.7", |
Release 1.5.2 with the addition of the compression middleware and updated package dependencies. Key changes include: