Fix dest already exists build errors
#9901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2566e2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markdalgleish
commented
Aug 22, 2024
| let dest = path.join(clientBuildDirectory, ssrAssetPath); | ||
| let dest = path.join(clientBuildDirectory, ssrAssetPath); | ||
|
|
||
| if (!fse.existsSync(dest)) { |
There was a problem hiding this comment.
Since (assuming no errors) we were guaranteed to either move the SSR asset or delete it depending on whether it's present in the client assets, it's much safer to use the file system as the source of truth rather than trying to infer what's on disk based on the Vite manifest.
github-actions
bot
added
the
awaiting release
This was referenced Aug 22, 2024
Closed
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9498.
This fix was inspired by #9800, but I decided to make this more error-proof by inspecting files on disk rather than inspecting the Vite manifest files/assets and potentially getting it wrong (as we have already).