Skip to content

chore: bump undici #10562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

chore: bump undici #10562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/young-avocados-ring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/node": patch
---

Bump `undici` to version `6.21.2` to address [security advisory](https://github.com/nodejs/undici/security/advisories/GHSA-c76h-2ccp-4975)
2 changes: 1 addition & 1 deletion packages/remix-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"cookie-signature": "^1.1.0",
"source-map-support": "^0.5.21",
"stream-slice": "^0.1.2",
"undici": "^6.11.1"
"undici": "^6.21.2"
},
"devDependencies": {
"@types/cookie-signature": "^1.0.3",
Expand Down
12 changes: 6 additions & 6 deletions packages/remix-server-runtime/__tests__/server-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,11 @@ describe("shared server runtime", () => {
loader() {
let headers = new Headers({ "x-test": "yes" });
let headersProxy = new Proxy(headers, {
get(target, prop, receiver) {
get(target, prop) {
if (prop === "set") {
throw new TypeError("immutable");
}
return Reflect.get(target, prop, receiver);
return target[prop].bind(target);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to change the way these tests were written to avoid the following error in 6.21.2:

TypeError: Cannot read private member #headersList from an object whose class did not declare it

},
});
// Mock a "response" that will pass the `isResponse` check
Expand Down Expand Up @@ -665,11 +665,11 @@ describe("shared server runtime", () => {
loader() {
let headers = new Headers({ "x-test": "yes" });
let headersProxy = new Proxy(headers, {
get(target, prop, receiver) {
get(target, prop) {
if (prop === "set") {
throw new TypeError("immutable");
}
return Reflect.get(target, prop, receiver);
return target[prop].bind(target);
},
});
// Mock a "response" that will pass the `isResponse` check
Expand Down Expand Up @@ -707,11 +707,11 @@ describe("shared server runtime", () => {
loader() {
let headers = new Headers({ "x-test": "yes" });
let headersProxy = new Proxy(headers, {
get(target, prop, receiver) {
get(target, prop) {
if (prop === "set") {
throw new TypeError("immutable");
}
return Reflect.get(target, prop, receiver);
return target[prop].bind(target);
},
});
// Mock a "response" that will pass the `isResponse` check
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.