Add Vite v6 support #10351
Open
Add Vite v6 support #10351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b5206b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markdalgleish
commented
Dec 19, 2024
Comment on lines
+41
to
+46
| test("Vite / dev / route added", async ({ page, browserName }) => { | ||
| test.skip( | ||
| browserName === "webkit", | ||
| "Safari caches too aggressively, browser manifest is cached with old routes" | ||
| ); | ||
|
|
There was a problem hiding this comment.
We also needed to do this in React Router, seems to be triggered by the Playwright update: remix-run/react-router#11511
markdalgleish
commented
Dec 19, 2024
| @@ -53,7 +53,7 @@ | |||
| "@octokit/graphql": "^4.8.0", | |||
| "@octokit/plugin-paginate-rest": "^2.17.0", | |||
| "@octokit/rest": "^18.12.0", | |||
| "@playwright/test": "^1.33.0", | |||
| "@playwright/test": "^1.49.1", | |||
There was a problem hiding this comment.
It's not clear to me why it was related, but attempting to run tests against Vite 6 raised some errors that are fixed in later versions of Playwright.
markdalgleish
commented
Dec 19, 2024
| @@ -14,7 +14,7 @@ tsconfig.tsbuildinfo | |||
| /fixtures/my-remix-app | |||
| /fixtures/deno-app | |||
| /integration/playwright-report | |||
| /test-results | |||
| test-results | |||
There was a problem hiding this comment.
I noticed the test-results directory within integration was showing up in my git diffs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.