Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-serve): remove redundant '@remix-run/node/install' import #10306

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kt3k
Copy link

@kt3k kt3k commented Dec 5, 2024

remix-serve cli seems calling installGlobals function of @remix-run/node package twice. In my usage, it's called with 2 different nativeFetch flags and that seems causing unnecessary dependency (@remix-run/web-fetch) loaded on the server runtime.

This PR removes the first call of installGlobals (by removing import of @remix-run/node/install), and tries to avoid the above situation.

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: e00f204

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@remix-run/serve Patch
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/fs-routes Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/route-config Patch
@remix-run/routes-option-adapter Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 5, 2024

Hi @kt3k,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 5, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title refactor: remove redundant '@remix-run/node/install' import fix(remix-serve): remove redundant '@remix-run/node/install' import Dec 5, 2024
@kt3k
Copy link
Author

kt3k commented Dec 11, 2024

Note:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants