Sync up status codes

remix-run · Jan 21, 2025 · 1d08edf · 1d08edf
1 parent dc6966a
commit 1d08edf
Showing 1 changed file with 13 additions and 19 deletions.
diff --git a/packages/remix-server-runtime/server.ts b/packages/remix-server-runtime/server.ts
@@ -54,6 +54,17 @@ export type CreateRequestHandlerFunction = (
   mode?: string
 ) => RequestHandler;
 
+// Do not include a response body if the status code is one of these,
+// otherwise `undici` will throw an error when constructing the Response:
+//   https://github.com/nodejs/undici/blob/bd98a6303e45d5e0d44192a93731b1defdb415f3/lib/web/fetch/response.js#L522-L528
+//
+// Specs:
+//   https://datatracker.ietf.org/doc/html/rfc9110#name-informational-1xx
+//   https://datatracker.ietf.org/doc/html/rfc9110#name-204-no-content
+//   https://datatracker.ietf.org/doc/html/rfc9110#name-205-reset-content
+//   https://datatracker.ietf.org/doc/html/rfc9110#name-304-not-modified
+const NO_BODY_STATUS_CODES = new Set([100, 101, 204, 205, 304]);
+
 function derive(build: ServerBuild, mode?: string) {
   let routes = createRoutes(build.routes);
   let dataRoutes = createStaticHandlerDataRoutes(build.routes, build.future);
@@ -410,16 +421,7 @@ async function handleSingleFetchRequest(
   let resultHeaders = new Headers(headers);
   resultHeaders.set("X-Remix-Response", "yes");
 
-  // Do not include a response body if the status code is one of these,
-  // otherwise `undici` will throw an error when constructing the Response:
-  //   https://github.com/nodejs/undici/blob/bd98a6303e45d5e0d44192a93731b1defdb415f3/lib/web/fetch/response.js#L522-L528
-  //
-  // Specs:
-  //   https://datatracker.ietf.org/doc/html/rfc9110#name-informational-1xx
-  //   https://datatracker.ietf.org/doc/html/rfc9110#name-204-no-content
-  //   https://datatracker.ietf.org/doc/html/rfc9110#name-205-reset-content
-  //   https://datatracker.ietf.org/doc/html/rfc9110#name-304-not-modified
-  let NO_BODY_STATUS_CODES = new Set([100, 101, 204, 205, 304]);
+  // Skip response body for unsupported status codes
   if (NO_BODY_STATUS_CODES.has(status)) {
     return new Response(null, { status, headers: resultHeaders });
   }
@@ -471,15 +473,7 @@ async function handleDocumentRequest(
 
   let headers = getDocumentHeaders(build, context);
 
-  // Do not include a response body if the status code is one of these,
-  // otherwise `undici` will throw an error when constructing the Response:
-  //   https://github.com/nodejs/undici/blob/bd98a6303e45d5e0d44192a93731b1defdb415f3/lib/web/fetch/response.js#L522-L528
-  //
-  // Specs:
-  //   https://datatracker.ietf.org/doc/html/rfc9110#name-204-no-content
-  //   https://datatracker.ietf.org/doc/html/rfc9110#name-205-reset-content
-  //   https://datatracker.ietf.org/doc/html/rfc9110#name-304-not-modified
-  let NO_BODY_STATUS_CODES = new Set([204, 205, 304]);
+  // Skip response body for unsupported status codes
   if (NO_BODY_STATUS_CODES.has(context.statusCode)) {
     return new Response(null, { status: context.statusCode, headers });
   }