Skip to content

Fix: Accessing Invalid Route with Loader present fails to show ErrorElement #13024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Fix: Accessing Invalid Route with Loader present fails to show ErrorElement #13024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bd6767
Fix: Handler loader errors before navigating
amubushar Feb 13, 2025
42601c8
add to contributors
amubushar Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
- amitdahan
- AmRo045
- amsal
- amubushar
- andreasottosson-polestar
- andreiduca
- antonmontrezor
Expand Down
2 changes: 1 addition & 1 deletion packages/react-router/lib/router/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,7 @@ export function createRouter(init: RouterInit): Router {
// in the normal navigation flow. For SSR it's expected that lazy modules are
// resolved prior to router creation since we can't go into a fallback
// UI for SSR'd apps
if (!state.initialized) {
if (!state.initialized && state.errors === null) {
startNavigation(NavigationType.Pop, state.location, {
initialHydration: true,
});
Expand Down