-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-react-router): add Deno support #12327
base: dev
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9211515 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @redabacha, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
@@ -512,19 +512,11 @@ async function doneStep(ctx: Context) { | |||
await sleep(200); | |||
} | |||
|
|||
type PackageManager = "npm" | "yarn" | "pnpm" | "bun"; | |||
|
|||
const packageManagerExecScript: Record<PackageManager, string> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the create-react-router project doesn't seem to have init script support that remix did so i've refactored this a little to simplify.
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
taken from remix-run/remix#9932. it's possible to detect older deno versions with
process.versions.deno
but i don't think it's worth doing.