Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to show hero win rate while selecting (Win rates is requesting from HSReplay) #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaksimMyshkin
Copy link

@MaksimMyshkin MaksimMyshkin commented Mar 28, 2019

I missed this feature as it helps to choose most powerfull class for run. Arena Tracker (https://github.com/supertriodo/Arena-Tracker) already have this feature. I will glad to see it in main repo.

ArenaHelperHeroWinRate

@rembound
Copy link
Owner

rembound commented Apr 9, 2019

Thanks for your contribution. Looks cool, but I don't know how useful it is, because the percentages are only marginally different, as the developers are trying to balance each hero.
I don't know if I want to add another external dependency to the plugin, because all of its data is currently stored in offline files for reliability.

@MaksimMyshkin
Copy link
Author

Actually, hero win rates may vary significantly. On screenshot is just top three classes. Professional arena players know this difference and consider this when they are choose a class. If you don't wont to accept this change than I will create another plugin maybe (or will support the fork). It's OK.

@riQQ
Copy link

riQQ commented Apr 11, 2019

I'm with MaksimMyshkin. Isn't it possible to only show it if the information is available?

@nathanmchoi
Copy link

Don't know if this is still on the table but would love to see implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants