-
-
Notifications
You must be signed in to change notification settings - Fork 371
Updated remark-mermaidjs
#1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updated remark-mermaidjs
#1439
Conversation
The package repository has been archived by the author in favour of `rehype-mermaid`. Signed-off-by: Ugo Baroncini <[email protected]>
Hi! It seems some of the things asked in the template are missing? Please edit your post to fill out everything.
You won’t get any more notifications from me, but I’ll keep on updating this comment, and remove it when done! If you need it, here’s the original template<!--
Please check the needed checkboxes ([ ] -> [x]).
Leave the comments as they are: they do not show on GitHub.
Please try to limit the scope,
provide a general description of the changes,
and remember it’s up to you to convince us to land it.
We are excited about pull requests.
Thank you!
-->
### Initial checklist
* [ ] I read the support docs <!-- https://github.com/remarkjs/.github/blob/main/support.md -->
* [ ] I read the contributing guide <!-- https://github.com/remarkjs/.github/blob/main/contributing.md -->
* [ ] I agree to follow the code of conduct <!-- https://github.com/remarkjs/.github/blob/main/code-of-conduct.md -->
* [ ] I searched issues and discussions and couldn’t find anything or linked relevant results below <!-- https://github.com/search?q=user%3Aremarkjs&type=issues and https://github.com/orgs/remarkjs/discussions -->
* [ ] I made sure the docs are up to date
* [ ] I included tests (or that’s not needed)
### Description of changes
TODO
<!--do not edit: pr-->
Thanks, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 138 138
=========================================
Hits 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin is deprecated, not broken. I suggest we remove it from the list instead.
if it is no longer suggested for use, then it is better to remove it from the list of suggestions. So 👍 to Remco’s suggestion. @pastacolsugo, can you instead remove it? |
The package repository has been archived by the author in favour of
rehype-mermaid
.Initial checklist
Description of changes
Changed plugin status in the list