Continue with Rails3 and start fixing Remarkable slowly #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored Gemspecs created by Jeweler so it is useable for Bundler - Renamed remarkable to remarkable_core so we can have a remarkable wrapper gem - Moved the Rails, Rspec and Remarkable versions to seperate files to make things DRY
- remove all tests that were meant for older Rails version before 2.3 - remove all RAILS_VERSION guards - add pending block around that were failing due to the lack of guards
When running tests we now rely on Bundler and not some combination of Rubygems and Jeweler 50 remarkable_activerecord specs are now failing due to the upgrade of Rails from 3.0.0.beta3 to 3.0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I did a big refactoring of the gemspecs and I cleaned up the Rakefiles. I also marked all (52) examples that are failing as pending so people can fix them one by one. You guys might not agree with everything I have changed, but I do think that these commits can bring Remarkabe back to live.
I'll continue with fixing the failings specs. Most of them are due to changes in ActiveRecord.
Please let me know if you have suggestions to improve things.
Jeroen