dual-axis plotting for N=2 channels#255
Open
cfanderson999 wants to merge 1 commit intoreilleya:stagingfrom
Open
dual-axis plotting for N=2 channels#255cfanderson999 wants to merge 1 commit intoreilleya:stagingfrom
cfanderson999 wants to merge 1 commit intoreilleya:stagingfrom
Conversation
reilleya
requested changes
Nov 1, 2025
Owner
reilleya
left a comment
There was a problem hiding this comment.
Looks good overall! Only thought is, do we want this to be a motor configuration value, or a global application one? I think the latter makes a bit more sense (and avoids further extending the already-long motor config menu) but I get that it would be scope creep. Happy to advise/help on adding another tab to the Preferences menu with general application settings if you are up for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#138 New boolean preference (defaults to FALSE) which toggles whether dual-axis plotting is to be used when number of channels is two.