Open
Conversation
OpenMotor now supports Star Grains from Burn Sim.
OpenMotor now supports Star Grains from Burn Sim.
AstroChuck
force-pushed
the
burnsim_star_grain_import
branch
from
e9c0104 to
28fea38
Compare
Contributor
Author
|
Hi Andrew, this branch should now merge cleanly with Staging, and the original artist bug in OM at the time this PR was opened has been fixed. This should be good for review now! |
Owner
|
Going to do a v0.6.1 release soon with a few minor features and bug fixes, and it would be great if this could be in it! Just pulled this branch down and tried it, and it doesn't look like it is working anymore: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenMotor now supports Star Grains from Burn Sim.
I'm not entirely sure this branch is ready to merge, since there appear to be base OpenMotor issues with drawing star grains (see #210 ) but in the interest of getting eyeballs on it, and possibly helping with the debugging, here it is.