fix: Matching generics in traits and structs #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue where if the trait and type both use the same generic type variable in a trait impl block, then the extractor would extract the generic parameter multiple times.
An example is
used to extract to
But now extracts to
This PR also tries to slightly clean up the end to end testing infrastructure. With the merging of #84 we can now lump a number of tests into a single noir/lampe project.
To this end I've added an
ExtractionTests
folder that starts the process of merging some of the simpler tests. For tests in theExamples/
folder that only check whether Lampe successfully extracts and parses the resulting extracted Lean correctly, we can start adding the tests as separate files in theExtractionTests
folder.