cmake: remove duplicate -Wl,-z,notext flags introduced in #1177 - #1190
Open
blshkv wants to merge 2 commits into
Open
cmake: remove duplicate -Wl,-z,notext flags introduced in #1177#1190blshkv wants to merge 2 commits into
blshkv wants to merge 2 commits into
Conversation
The flag was already added unconditionally before the first set_target_properties call, but was also prepended inside each of the three branches (Android / non-Android Xash / non-Xash), resulting in it being appended to LINK_FLAGS four times total. Remove the three redundant copies; the single unconditional addition is sufficient.
Author
|
The Linux CI check is failing due to transient apt 404 errors on Debian Bullseye security mirrors (Bullseye is EOL), not related to this PR. Windows build passes fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1177 added
-Wl,-z,notextunconditionally before the firstset_target_propertiescall, which is correct and sufficient. However, the same flag was also prepended toLINK_FLAGSinside each of the threeset_target_propertiesbranches (Android, non-Android Xash, non-Xash), causing it to be appended toLINK_FLAGSfour times total.This PR removes the three redundant copies, keeping only the single unconditional addition.