regamedll: remove -s strip flag to preserve linker markers - #1176
Merged
Conversation
The -s flag strips all symbols from the output shared library, including sentinel symbols used by packaging systems to verify LDFLAGS were respected (e.g. Gentoo's __gentoo_check_ldflags__). Same issue fixed in the sibling project: rehlds/Metamod-R#93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LINK_FLAGSis initialized to"-s"in the non-debug branch, which causesstripto run on the output shared library. This removes all symbols including sentinel symbols used by packaging systems to verify thatLDFLAGSwere respected. For example, Gentoo injects--defsym=__gentoo_check_ldflags__=0intoLDFLAGSand checks the resulting binary still contains it —-sdestroys that symbol, causing a QA failure.Fix
Replace
set(LINK_FLAGS "-s")withset(LINK_FLAGS ""). Stripping should be left to the build system or packager.Related
Same issue was fixed in sibling projects under the same vendor:
-fltofrom HLTV components with the same non-PIC i386 pattern)