chore: use seperate Xresource keys for lock program #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoumyaRanjanPatnaik
force-pushed
the
chore/seperate-keys-for-lock-program
branch
from
f77214f to
fe8b80d
Compare
|
I guess another way we could have modeled WM variance (i3/sway) would have been to specify distinct roots for i3 and sway XResource roots. Unsure of the relative pros/cons over the path we choose. |
|
I thought of that actually. That's the original solution that we though of in the issue (see this comment). But it seemed inconsistent with the convention we've been following. |
|
I actually couldn't find a single other instance where sway and i3 would require different resources |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the lock program doesn't work across the wayland and x11 sessions. This is a challenge since most locking software only supports one of the ecosystems.
BREAKING CHANGE: This PR splits the XResource key
wm.program.lockfor the lock program intowm.program.lock_swayandwm.program.lock_i3.NOTE: This change may require a change in documentation
FIXES: regolith-linux/regolith-powerd#3