Skip to content

Don't include footer row in example values during mapping #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossjones merged 1 commit into from
Sep 2, 2025
Merged

Don't include footer row in example values during mapping #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/importer/src/dudk/sheets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,12 @@ exports.GetColumnValues = (sid, sheet, columnIndex, cellWidth = 30, count = 10)
// Limit to just the column we want
dataRange.start.column += columnIndex;
dataRange.end.column = dataRange.start.column;

// The range passed to SessionGetInputValues is inclusive, and therefore
// we end up with the first row of the selected footer. To avoid this
// we will decrement the end.row to ensure we don't pull too make values.
dataRange.end.row = dataRange.end.row - 1

let values = backend.SessionGetInputValues(
sid,
dataRange,
Expand Down
Loading