Skip to content

[enhancement] Only print performance variable reference values if defined #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[enhancement] Only print performance variable reference values if defined #3517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion reframe/frontend/executors/policies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,13 @@ def _print_perf(task):
for key, info in perfvars.items():
val, ref, lower, upper, unit, result = info
name = key.split(':')[-1]
msg = f'P: {name}: {val} {unit} (r:{ref}, l:{lower}, u:{upper})'

# Build reference info string only if all three reference value components are defined
if ref is not None and lower is not None and upper is not None:
Copy link
Contributor

@vkarak vkarak Jul 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the check here to

Suggested change
if ref is not None and lower is not None and upper is not None:
if ref is not None:

Because otherwise it will mask out cases where the reference is set, but not the thresholds. Also are you sure that checking the reference against None is correct. I think when it's missing we are setting it to 0:

reframe/reframe/core/pipeline.py

Line 2440 in e3c4b30

ref = (0, None, None)

msg = f'P: {name}: {val} {unit} (r:{ref}, l:{lower}, u:{upper})'
else:
msg = f'P: {name}: {val} {unit}'

if result == 'xfail':
msg = color.colorize(msg, color.MAGENTA)
elif result == 'fail' or result == 'xpass':
Expand Down
Loading