Skip to content

chore: remove serverless from peer dependencies#127

Merged
mosufy merged 1 commit intoreflex-media:masterfrom
renesansz:feature/remove-serverless
Mar 26, 2026
Merged

chore: remove serverless from peer dependencies#127
mosufy merged 1 commit intoreflex-media:masterfrom
renesansz:feature/remove-serverless

Conversation

@renesansz
Copy link
Copy Markdown
Collaborator

osls is now the primary deployment tool with optional peer dependency. The bin script's fallback logic (osls → serverless) preserves backward compatibility if serverless is installed globally or locally.

Why this is sufficient

  • Removing the peer dep entry stops npm from warning/requiring serverless during install
  • The bin script's fallback logic already makes serverless work transparently if it happens to be installed globally or locally by the consumer
  • No TypeScript types, no imports, no runtime code references serverless directly

Verification

  1. npm install in a fresh consumer project should produce no peer dependency warnings about serverless
  2. If serverless is installed, lesgo-scripts.sh still resolves and uses it correctly (fallback path still present in the script)
  3. If only osls is installed, the script uses osls as before

@renesansz renesansz added the dependencies Pull requests that update a dependency file label Mar 26, 2026
Copilot AI review requested due to automatic review settings March 26, 2026 02:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes serverless from peerDependencies to avoid peer-dep install warnings, while keeping osls as the (optional) peer dependency for deployment tooling.

Changes:

  • Removed serverless from peerDependencies.
  • Removed the corresponding peerDependenciesMeta.serverless optional flag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
osls is now the primary deployment tool with optional peer dependency.
The bin script's fallback logic (osls → serverless) preserves backward
compatibility if serverless is installed globally or locally.
@renesansz renesansz force-pushed the feature/remove-serverless branch from 543f3fc to d17a9bb Compare March 26, 2026 02:20
Copy link
Copy Markdown
Collaborator

@daison12006013 daison12006013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me, the locked file was updated too!

@mosufy mosufy merged commit 1a7deb3 into reflex-media:master Mar 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Development

Successfully merging this pull request may close these issues.

4 participants