chore: remove serverless from peer dependencies#127
Merged
mosufy merged 1 commit intoreflex-media:masterfrom Mar 26, 2026
Merged
chore: remove serverless from peer dependencies#127mosufy merged 1 commit intoreflex-media:masterfrom
mosufy merged 1 commit intoreflex-media:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes serverless from peerDependencies to avoid peer-dep install warnings, while keeping osls as the (optional) peer dependency for deployment tooling.
Changes:
- Removed
serverlessfrompeerDependencies. - Removed the corresponding
peerDependenciesMeta.serverlessoptional flag.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
osls is now the primary deployment tool with optional peer dependency. The bin script's fallback logic (osls → serverless) preserves backward compatibility if serverless is installed globally or locally.
543f3fc to
d17a9bb
Compare
daison12006013
approved these changes
Mar 26, 2026
Collaborator
daison12006013
left a comment
There was a problem hiding this comment.
🚀 Looks good to me, the locked file was updated too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osls is now the primary deployment tool with optional peer dependency. The bin script's fallback logic (osls → serverless) preserves backward compatibility if serverless is installed globally or locally.
Why this is sufficient
serverlessduring installserverlesswork transparently if it happens to be installed globally or locally by the consumerserverlessdirectlyVerification
npm installin a fresh consumer project should produce no peer dependency warnings aboutserverlessserverlessis installed,lesgo-scripts.shstill resolves and uses it correctly (fallback path still present in the script)oslsis installed, the script usesoslsas before