Skip to content

Conversation

bnjmnjrk
Copy link

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them:
    I am working in a restricted environment where high-level tools like cURL aren't installed by default, so I have to create large workarounds to collect all the necessary dependencies that aren't native to Python. It would be great if the project could use wget instead of curl, as wget is much deeper in the OS dependency tree than curl. In fact, wget is a dependency of the coreutils package, so we can assume that everyone has it installed.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR replaces curl with wget in the bun installation script (scripts/bun_install.sh) to improve compatibility in restricted environments. The change specifically affects line 145 where the download command switches from curl --fail --location --progress-bar --output to wget --quiet --show-progress --output-document=.

Bun is a JavaScript runtime and toolkit that Reflex uses for its frontend build process. The installation script is responsible for downloading the appropriate bun binary for the user's system. By switching to wget, the script becomes more compatible with minimal environments where curl might not be available but wget is included as part of the coreutils package.

The change maintains identical functionality - both commands download a file from a URL and save it locally with error handling. The author's assumption is that wget has deeper OS integration and broader availability across different systems, particularly in containerized or restricted environments where package installations are minimized.

Additionally, there appears to be an unrelated subproject update to reflex-examples which is likely just a routine dependency update and not part of the core wget/curl change.

Confidence score: 2/5

  • This PR introduces potential cross-platform compatibility issues as wget may not be available on all systems, particularly macOS
  • Score reflects the risk of breaking existing installations on systems where wget is not present by default
  • Pay close attention to the bun installation script as this change could affect the initial setup experience for new users

2 files reviewed, 1 comment

Edit Code Review Bot Settings | Greptile

@adhami3310
Copy link
Member

is there an issue with curl? btw i encourage you to make this upstream https://github.com/oven-sh/bun/blob/main/src/cli/install.sh and we try to minimize our differences with that

@adhami3310
Copy link
Member

linking upstream ticket: oven-sh/bun#21785

@adhami3310
Copy link
Member

btw if you install bun in the machine (through whatever means work in your environment), reflex will reuse that and not download bun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants