move rx config away from pydantic #5557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Major architectural change to replace Pydantic with Python's native dataclasses in Reflex's configuration system, simplifying dependencies while maintaining functionality.
- Converted
reflex/config.pyfrom Pydantic models to@dataclassdecorators with split into BaseConfig/Config classes - Changed error handling in tests from ValueError to TypeError reflecting stricter type validation
- Modified Tailwind configuration to rely on plugin clearing instead of explicit config flag setting
- Changed frontend port validation to use integer (3005) instead of string ('3005') type
- Added pyright type ignore comments to handle known edge cases
3 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5557 will not alter performanceComparing Summary
|
masenf
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #5438