-
Notifications
You must be signed in to change notification settings - Fork 1.6k
More env var cleanup #4248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More env var cleanup #4248
Conversation
|
todo: add a flag to disable edit: i created #4253 |
masenf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall i like the descriptor implementation
i'm not too sure about .get being a property though, to me that kind of looks weird. did you consider having it as a normal method like .set(...)
@adhami3310 wondering if you have any input here as well
Thanks, I wanted to try binding the descriptors to
Yeah, I was thinking about making it a normal method… This would also allow us to add f.e. a |
yea that would be great |
|
Refactor done ✔️ |
closes #4172