-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Minify state names #3728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
benedikt-bartscher
wants to merge
38
commits into
reflex-dev:main
Choose a base branch
from
benedikt-bartscher:minify-state-names-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Minify state names #3728
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
673c488
wip minified state names
benedikt-bartscher 0c406f4
cleanup
benedikt-bartscher 1b0577a
all _state_names should be classvars
benedikt-bartscher bae98e8
fix hardcoded event handlers and states
benedikt-bartscher 8fc8fd9
fix state name init for substates, thanks @masenf
benedikt-bartscher 51aef9f
enable minified state names by default in prod
benedikt-bartscher 7bf15b4
add simple test that minified state names are unique
benedikt-bartscher e9cedd2
fix default state names
benedikt-bartscher 7287c3a
fix typo
benedikt-bartscher 215a834
wip minified state integration test
benedikt-bartscher dadfb56
wip: more dynamic jinja contexts, tests for minification
benedikt-bartscher 4e76e4d
fix type ignore comment
benedikt-bartscher 79fc109
move state.js to jinja, related to #3738
benedikt-bartscher c26d626
Revert "move state.js to jinja, related to #3738"
benedikt-bartscher f163d41
pass constants via js consts to state.js
benedikt-bartscher 4bbd988
test_minified_states: remove skip -- things seem to be working as-is
masenf 6eb808c
state.js: more reliable isStateful detection
masenf db2b5b0
AppHarness: handle `get_state_name` for minified names
masenf d326047
implement default_factory for EnvVar, improve env_var typing
benedikt-bartscher 4116ab9
do not set appharness env twice, already done in AppHarnessProd
benedikt-bartscher 84c14a1
cleanup conflicts
benedikt-bartscher bcd0cf8
Merge remote-tracking branch 'upstream/main' into minify-state-names-v2
benedikt-bartscher 24caf5f
cleanup unnecessary or False
benedikt-bartscher 46fefcf
Merge remote-tracking branch 'upstream/main' into minify-state-names-v2
benedikt-bartscher f94328f
delete unused function, add cleanup fixture for test_is_prod_mode
benedikt-bartscher 6ce9471
set env mode before importing modules that contain rx.State subclasses
benedikt-bartscher 74c336f
forgot ruffing
benedikt-bartscher 2e12feb
darglinting it
benedikt-bartscher 1ef54ec
Merge remote-tracking branch 'upstream/main' into minify-state-names-v2
benedikt-bartscher 3dd6e9c
Merge remote-tracking branch 'upstream/main' into minify-state-names-v2
benedikt-bartscher a639f52
add typing to function vars (#4372)
adhami3310 a154a7d
Add template name to reflex init success msg (#4349)
ElijahAhianyo 1e45a8e
Update bug_report.md (#4382)
Alek99 5840c0a
Merge remote-tracking branch 'upstream/main' into minify-state-names-v2
benedikt-bartscher 0be2c3e
fix: properly cleanup env vars with pytest fixtures
benedikt-bartscher d8def13
Merge remote-tracking branch 'upstream/main' into minify-state-names-v2
benedikt-bartscher 0262143
prevent env api breaking change
benedikt-bartscher 5c9839e
Merge remote-tracking branch 'upstream/main' into minify-state-names-v2
benedikt-bartscher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.