-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-4005] Proxy backend requests on '/' to the frontend #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the optional extra `proxy` is installed, then the backend can handle all requests by proxy unrecognized routes to the frontend nextjs server.
masenf
changed the title
[WiP] Proxy backend requests on '/' to the frontend
[ENG-4005] Proxy backend requests on '/' to the frontend
Nov 1, 2024
…ntent with proxying enabled by default in dev mode, both frontend and backend ports on / should return the same content.
Fix log level passing to subprocess
if the port is up or not, we don't really care... the HTTP request needs to work and not return errors
adhami3310
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the optional extra
proxy
is installed, then the backend can handle all requests by proxy unrecognized routes to the frontend nextjs server.First attempt at #3296, and it actually works surprisingly well; even with hot-reload in dev mode.
Future work:
don't set this up in backend-only mode (not sure how to detect this currently)update the log output to make it more obvious what is happening