-
Notifications
You must be signed in to change notification settings - Fork 9
Expand model language #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…efinition
For SLD db resolver search for name or interpret ID={number} directly
…x model object for analytic function for mixing materials
… automatically generated by black for "def a(b): ..."
… string, fix some bugs
…function in class constant
…ack_class entry first in yaml
…nd SubStackType replacement mechanism
…SubStack depth that might become indefinately deep
tomarnoldess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good enough for review at the coming orso meeting.
The rLL decription should allow for one or more of the variables defined in LL to be redefined as well as being put in the reverse order.
i'm not sure i understand the top level syntax: Si | ( LL | rLL ) in D2O | 2 ( LL | rLL ) | water
- what is the "2" doing in this?
- what is the point of defining D2O as part of one of the bilayers? is it different from the water? how does it relate to the "default_solvent"?
- are there some implied constraints?
|
The stack string syntax is basically an extension of what was already there for Everythig inside of brackets is a stack within a (unnamed) The Currently the definition of the LipidLeaflet is based on me lookin in the refnx docs, just adopting the total thickness to be a separate parameter so one can use the stack string to set it. In refnx I saw that all of this is defined within some kind of solvent and that this could actually come from some sort of parent structure. So
As I don't have any idea how these models are typically build, some of these assumptions may be wrong. So if you don't find the solvent option actually useful, we can think how to parameterize such structures best. |
|
Sorry, I've not had chance to read the PR yet. However, some explanation of refnx design may be useful here. A refnx Now let's consider a Don't forget that Most non- These design details add a lot of sophistication and power to the analysis. However, the sophistication may be difficult to insert into a common framework like the ORSO model language, as different analysis package approaches things slightly differently. For an example of how |
|
As was discussed during the sample model session, we will merge these changes already agreed. LipidLeaflet was removed as parameterization was not yead defined with the community. I'll create another PR speicfically for that discussion. |
This is the first step towards expanding the ORSO model language to more complex cases including physics models in soft-matter. Please be free to give your opinions and ideas for improvements.
Features that were added:
Example of a set of lipi bi-layers:
Example of a user defined functional form of SLD profile: