-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add support for Mobility #149
Open
bricesanchez
wants to merge
11
commits into
master
Choose a base branch
from
feature/mobility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−71
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3ebfa81
Add support for Mobility
bricesanchez 40cccd5
Update ruby versions in travis config
bricesanchez 38c7ea6
Remove mobility gem source
bricesanchez add4cd0
Update dependency to refinerycms-core
bricesanchez 76e49d1
Add optional: true to belongs_to relation with :page
bricesanchez 7a9d50b
Downgrade ruby versions in travis config
bricesanchez 508f7a6
Add dependency to refinerycms-images
bricesanchez 663bd19
Apply Refinery::Page decorators only if defined
bricesanchez 1fe5866
Gemfile: switch back to master branch of refinerycms
bricesanchez 6032bd2
Now use Module#prepend for decorators
bricesanchez 77a923b
Change capybara locator to find, match: :first, so it will handle mul…
anitagraham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 10 additions & 15 deletions
25
db/migrate/20110511215016_translate_page_image_captions.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,17 @@ | ||
class TranslatePageImageCaptions < ActiveRecord::Migration[4.2] | ||
def up | ||
add_column Refinery::ImagePage.table_name, :id, :primary_key | ||
def change | ||
create_table :refinery_image_page_translations do |t| | ||
|
||
Refinery::ImagePage.reset_column_information | ||
unless defined?(Refinery::ImagePage::Translation) && Refinery::ImagePage::Translation.table_exists? | ||
Refinery::ImagePage.create_translation_table!({ | ||
:caption => :text | ||
}, { | ||
:migrate_data => true | ||
}) | ||
end | ||
end | ||
# Translated attribute(s) | ||
t.text :caption | ||
|
||
def down | ||
Refinery::ImagePage.reset_column_information | ||
t.string :locale, null: false | ||
t.integer :refinery_image_page_id, null: false | ||
|
||
Refinery::ImagePage.drop_translation_table! :migrate_data => true | ||
t.timestamps null: false | ||
end | ||
|
||
remove_column Refinery::ImagePage.table_name, :id | ||
add_index :refinery_image_page_translations, :locale, name: :index_refinery_image_page_translations_on_locale | ||
add_index :refinery_image_page_translations, [:refinery_image_page_id, :locale], name: :index_114aab0bbdedc79d0ec4f4b, unique: true | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this causes an
Unknown primary key for table refinery_image_pages in model Refinery::ImagePage.
error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not because i've made this change too : https://github.com/refinery/refinerycms-page-images/pull/149/files#diff-cfa073f65992007a3d91e1efad7b811bL3