Repository navigation
#233 Bring the HTML Report to parity with https://refactorfirst.github.io/ reports #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e2ddef6
Adding feature parity plans
jimbethancourt d986944
#233 Bring the htmlReport report to feature parity with refactorfirst…
jimbethancourt 68ef835
Fixed failing tests
jimbethancourt 30e08d9
Update .gitignore to include node test dependencies
jimbethancourt cef08b9
Making z-index adjustments for better visibility
jimbethancourt 9324b78
Apply CodeRabbit fixes
jimbethancourt 9fc5615
Fixed theme selector contrast in dark mode
jimbethancourt 27bfbe1
Potential fix for pull request finding 'CodeQL / Workflow does not co…
jimbethancourt 553d30a
Potential fix for pull request finding 'CodeQL / Workflow does not co…
jimbethancourt 1fb6a26
Potential fix for pull request finding 'CodeQL / Bad HTML filtering r…
jimbethancourt 237748a
Potential fix for pull request finding 'CodeQL / Bad HTML filtering r…
jimbethancourt c991dc3
Fix E2E fixture test selection across Maven modules while requiring r…
coderabbitai[bot] 29451a0
Fix report focus handling, graph cleanup, table behavior, and dark ch…
coderabbitai[bot] f975f74
Limit strict report test selection to the E2E fixture generation profile
coderabbitai[bot] 6ad4692
Fix report asset injection, tooltip escaping, graph cleanup, accessib…
coderabbitai[bot] fc29402
Fixed code causing renderInteractivePage_rendersNoGitMessageInsteadOf…
jimbethancourt 884cc9c
Fixed CodeQL issues
jimbethancourt 78d0c25
Fixed formatting issues in the package table
jimbethancourt d80db5f
Fixed formatting issue in the Significant Duplication table
jimbethancourt e4293d2
Push up refactor-first.json to test it
jimbethancourt 2d4b10b
Apply CodeRabbit fixes
jimbethancourt 70ac883
Fix report link activation, sticky header offsets, and cycle navigati…
coderabbitai[bot] 122e928
Apply CodeRabbit fixes
jimbethancourt 035c36f
Fix report URL encoding, graph popup races and theme restoration; har…
coderabbitai[bot] 625eae9
Fix report template test fixtures to supply resolved URLs and expect …
coderabbitai[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| language: en-US | ||
|
|
||
| reviews: | ||
| profile: chill | ||
| path_filters: | ||
| - "!junit4-report.html" | ||
| - "!fxgl-report.html" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: Report E2E | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
|
|
||
| jobs: | ||
| e2e: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Check out Git repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up JDK 25 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '25' | ||
| distribution: 'temurin' | ||
| cache: maven | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
|
|
||
| - name: Generate Fixture Reports | ||
| run: mvn -B -pl report -am install -Dtest=SampleReportGenerationTest -DfailIfNoTests=false | ||
|
|
||
| - name: Install Playwright Browsers | ||
| run: | | ||
| cd report/e2e | ||
| npm install | ||
| npx playwright install --with-deps chromium | ||
|
|
||
| - name: Run E2E Tests | ||
| run: | | ||
| cd report/e2e | ||
| npx playwright test | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Report JS Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| js-tests: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Check out Git repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
|
|
||
| - name: Build With Maven | ||
| run: mvn -B -pl report -am install -DskipTests | ||
|
|
||
| - name: Run Report JavaScript Tests | ||
| run: mvn -B -pl report -P js-tests verify | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable the specified-test failure for upstream modules.
With
-am, Maven applies-Dtest=SampleReportGenerationTestto upstream modules that do not contain this test. Surefire fails on unmatched explicit test selections by default.-DfailIfNoTests=falsecontrols a different setting, so fixture generation stops before Playwright runs. Add-Dsurefire.failIfNoSpecifiedTests=false. The inspected POMs do not override this setting. (maven.apache.org)GitHub Check: CodeQL
[warning] 11-41: Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
zizmor (1.31.1)
[warning] 10-42: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)