Issue232 #237
Closed
Issue232 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed prog_uchar to unsigned char changed prog_uint16_t to uint16_t
The case checking for displaying the 12 hour format was incorrect. It would display 12:00 PM (aka, noon) as 00:00 PM. close reefangel#232
The previous attempt only fixed displaying 12:00 pm properly and did not handle midnight. This fix handles displaying midnight properly as well. ** The other changes in the file are my editor removing the trailing whitespace and blanks **
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just tested out my controller and fixed the 12 hour display bug that I reported (#232). Both midnight and lunch/noon display the 12 properly along with their respective AM/PM.
This branch was also created based off my fixing of the compiler warnings in the other pull request ( #236)
Also, my editor fixed a lot of other areas of the files by removing the additional whitespace from the lines.