Skip to content

Deep match actions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Deep match actions #5

wants to merge 3 commits into from

Conversation

tarling
Copy link

@tarling tarling commented Oct 12, 2017

Lodash's findIndex is currently used in src/asserts/utils/assertDispatchedActions.js and src/asserts/utils/assertNotDispatchedActions.js for comparing actions against expected actions. This will give a false positive in some cases. e.g. it will match:

{ type: '0', payload: [{ a: '0' }, { b: '1' }, { c: '2' }] }

against

{ type: '0', payload: [] }

Suggest isEqual is used as a predicate in findIndex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant