remove unused MacOS quill signing logic #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I spoke too soon I think. We need to revert this - otherwise next release cut of RP will fail at this point. I was confused about the goreleaser files of connect vs rpk's. I will prep the revert and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code path is unused.
Currently only place we do any signing is when we statically bundle
connectwithrpkon therpkhomebrew tap. That path does not actually use this.goreleaser.ymlfile. Note also thatquillis not installed and none of the signing secrets are ever present when using this.goreleaser.ymlin any case.In very near future, we will do away with static bundling altogether.