Merge pull request #2811 from redpanda-data/fix-lints

Fix lints and add missing cloud components

.goreleaser.yml

@@ -43,19 +43,6 @@ builds:
       -X main.DateBuilt={{.Date}}
       -X main.BinaryName=redpanda-connect
 
-  - id: connect-community
-    main: cmd/redpanda-connect-community/main.go
-    binary: redpanda-connect
-    goos: [ darwin, linux ]
-    goarch: [ amd64, arm64 ]
-    env:
-      - CGO_ENABLED=0
-    ldflags: >
-      -s -w
-      -X main.Version={{.Version}}
-      -X main.DateBuilt={{.Date}}
-      -X main.BinaryName=redpanda-connect
-
   - id: connect-lambda
     main: cmd/serverless/connect-lambda/main.go
     binary: redpanda-connect-lambda
@@ -90,15 +77,6 @@ archives:
       - CHANGELOG.md
       - licenses
 
-  - id: connect-community
-    builds: [ connect-community ]
-    format: tar.gz
-    name_template: 'redpanda-connect-community_{{ .Version }}_{{ .Os }}_{{ .Arch }}{{ with .Arm }}v{{ . }}{{ end }}{{ with .Mips }}_{{ . }}{{ end }}{{ if not (eq .Amd64 "v1") }}{{ .Amd64 }}{{ end }}'
-    files:
-      - README.md
-      - CHANGELOG.md
-      - licenses
-
   - id: connect-lambda
     builds: [ connect-lambda ]
     format: zip

internal/impl/aws/processor_bedrock.go

@@ -17,6 +17,7 @@ import (
 	"github.com/aws/aws-sdk-go-v2/service/bedrockruntime"
 	bedrocktypes "github.com/aws/aws-sdk-go-v2/service/bedrockruntime/types"
 	"github.com/redpanda-data/benthos/v4/public/service"
+
 	"github.com/redpanda-data/connect/v4/internal/impl/aws/config"
 )
 

internal/impl/azure/integration_test.go

@@ -208,7 +208,7 @@ input:
 		require.True(t, pager.More())
 		page, err := pager.NextPage(ctx)
 		require.NoError(t, err)
-		require.Len(t, page.Segment.BlobItems, 0)
+		require.Empty(t, page.Segment.BlobItems)
 	})
 
 	t.Run("blob_storage_append", func(t *testing.T) {

internal/impl/cassandra/output.go

@@ -286,14 +286,14 @@ func (d *decorator) Attempt(q gocql.RetryableQuery) bool {
 	return true
 }
 
-func getExponentialTime(min, max time.Duration, attempts int) time.Duration {
-	minFloat := float64(min)
+func getExponentialTime(minDur, maxDur time.Duration, attempts int) time.Duration {
+	minFloat := float64(minDur)
 	napDuration := minFloat * math.Pow(2, float64(attempts-1))
 
 	// Add some jitter
 	napDuration += rand.Float64()*minFloat - (minFloat / 2)
-	if napDuration > float64(max) {
-		return max
+	if napDuration > float64(maxDur) {
+		return maxDur
 	}
 	return time.Duration(napDuration)
 }

internal/impl/gcp/integration_pubsub_test.go

@@ -33,7 +33,6 @@ import (
 
 func TestIntegrationGCPPubSub(t *testing.T) {
 	integration.CheckSkip(t)
-	t.Parallel()
 
 	pool, err := dockertest.NewPool("")
 	require.NoError(t, err)
@@ -55,7 +54,7 @@ func TestIntegrationGCPPubSub(t *testing.T) {
 		assert.NoError(t, pool.Purge(resource))
 	})
 
-	require.NoError(t, os.Setenv("PUBSUB_EMULATOR_HOST", fmt.Sprintf("localhost:%v", resource.GetPort("8681/tcp"))))
+	t.Setenv("PUBSUB_EMULATOR_HOST", fmt.Sprintf("localhost:%v", resource.GetPort("8681/tcp")))
 	require.NotEqual(t, "localhost:", os.Getenv("PUBSUB_EMULATOR_HOST"))
 
 	_ = resource.Expire(900)

internal/impl/ollama/base_processor.go

@@ -29,6 +29,7 @@ import (
 	"github.com/dustin/go-humanize"
 	"github.com/ollama/ollama/api"
 	"github.com/redpanda-data/benthos/v4/public/service"
+
 	"github.com/redpanda-data/connect/v4/internal/singleton"
 )
 

public/schema/cloud_allow_list.txt

@@ -65,19 +65,28 @@ websocket
 workflow
 
 # Broker and operational types
+branch
 broker
+catch
+parallel
+processors
 switch
+for_each
 drop
 batched
 resource
 inproc
+insert_part
 sequence
 read_until
 sync_response
+try
 drop_on
 fallback
 reject
 reject_errored
 retry
 switch
 none
+while
+