Remove enable_yui_compressor

[boekkooi]

Remove enable_yui_compressor as a option since this can be handled by using assetic configuration like:

assetic:
    # java: "/usr/bin/java"
    filters:
        yui_css:
            jar: "%kernel.root_dir%/Resources/java/yuicompressor.jar"
            apply_to: "\.css$"
        yui_js:
            jar: "%kernel.root_dir%/Resources/java/yuicompressor.jar"
            apply_to: "\.js$"

This should be a better way and reduce some template and configuration code.

[janxin]

Would you like to take care of fixing this issue?

[janxin]

@boekkooi I've started to look at this issue. I've removed the stylesheets assetic declaration and I've replaced it as follows:

{% stylesheets filter='cssrewrite' 'components/redkitecms/twitter-bootstrap/3.x/css/bootstrap.min.css'
                                            'components/redkitecms/font-awesome/css/font-awesome.min.css'
                                            'bundles/redkitecms/css/skins/bootstrap/skin.css'
                                            'bundles/redkitecms/css/skins/bootstrap/skin_3.x.css'
                                            'components/redkitecms/jquery-ui/themes/smoothness/*'   
                                            'bundles/redkitelabselfinder/vendor/ElFinder/vendor/jquery-ui.css'
                                            'bundles/redkitelabselfinder/vendor/ElFinder/css/elfinder.min.css'
                                            'bundles/redkitelabselfinder/vendor/ElFinder/css/theme.css'
%} 
<link href="{{ asset_url }}" rel="stylesheet" type="text/css" media="all" />
{% endstylesheets %}

then I've changed the config_rkcms.yml as follows:

assetic:
debug: %kernel.debug%
use_controller: false
bundles: [RedKiteCmsBundle]
filters:
cssrewrite: ~
yui_css:
jar: %kernel.root_dir%/Resources/java/yuicompressor.jar
apply_to: ".css$"
yui_js:
jar: %kernel.root_dir%/Resources/java/yuicompressor.jar
apply_to: ".js$"

but I've noticed it takes a long time (5 mins) to compile assets when I run assetic:dump: what I'm doing wrong?

[boekkooi]

Mhh probably a problem with YUI it self. I'm using:

assetic:
    debug:          %kernel.debug%
    use_controller: false
    bundles:        [ RedKiteCmsBundle ]
    node_paths:     [/usr/lib/node_modules/]
    filters:
        cssrewrite: ~
        less:
          apply_to: "\.less$"
        uglifyjs2:
          apply_to: "\.js$"
        uglifycss:
          apply_to: "\.css$"

And it works like a charm.

What maybe a reason is that when using apply_to all js and css files that use stylesheets and javascripts (within a twig template) are compressed and this takes longer?

[boekkooi]

Also are you using the latest version (https://github.com/yui/yuicompressor/releases) ?

[boekkooi]

Are you currently working on this? If not I will pick it!

[janxin]

Yes I started to inspect it, but I will gladly let it go.

Thanks

[boekkooi]

Ok then I will pick it up because YUI totally destroyed my capifony deploy

[janxin]

This patch assumes to remove the yuicompressor from RedKIteCmsSandbox and let the user to choose a compressor, don't it?

[boekkooi]

Correct, i also added a pull for the ThemeEngineBundle (see redkite-labs/ThemeEngineBundle#1)