fix: handle ClusterPipeline missing nodes_manager attribute (#365) #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add get_protocol_version wrapper to safely handle ClusterPipeline objects - ClusterPipeline objects lack nodes_manager attribute, causing AttributeError - Fallback to protocol "3" when unable to detect version from cluster pipelines - Handle both sync and async ClusterPipeline cases Fixes #365
rbs333
approved these changes
Sep 23, 2025
| logger.debug( | ||
| "AsyncClusterPipeline without valid _redis_cluster, defaulting to protocol 3" | ||
| ) | ||
| return "3" |
There was a problem hiding this comment.
@bsbodden could you help me unpack this fix a bit?
So we were failing before because the objects was trying to use an attribute nodes_manager that didn't exist. The fix implemented here checks the protocol version and defaults to 3 in the case of not knowing.
Was the fail happening because it was previously defaulting to "2" when in cluster mode vs with other connections types?
I haven't done a ton with protocols in redis so trying to understand some of those key differences.
There was a problem hiding this comment.
Well shit, it should be 2, not 3 - and I was just able to get a real integration test working with my cluster setup and this won't cut it. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365