Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test-utils): remove TypeScript ignore directives for socket port #2915

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

spavlov6
Copy link
Contributor

@spavlov6 spavlov6 commented Mar 24, 2025

Description

Remove ts-ignore from (test-utils) index.ts file
The "dockerPromise" property "port" matches the socket options "port" property (type: number)
Types match with no issues, tsx runs with no issues, all tests run with no issues.
Nothing else is mentioned about this todo, so I assumed it was related to the types.


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@bobymicroby bobymicroby merged commit 924dafa into redis:master Mar 26, 2025
11 checks passed
@bobymicroby
Copy link
Member

@spavlov6 Thank you for your contribution!

@spavlov6 spavlov6 deleted the cleanup/unnecessary-ts-ignores branch March 26, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants