Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate test to JUnit5 #4139

Merged
merged 29 commits into from
Apr 9, 2025
Merged

Migrate test to JUnit5 #4139

merged 29 commits into from
Apr 9, 2025

Conversation

ggivo
Copy link
Collaborator

@ggivo ggivo commented Apr 7, 2025

More or less trivial change to migrate existing test from JUnit 3/4 to JUnit 5

  • JUnit 4 is feature-frozen. Last released version 2021
  • JUnit 5 is actively maintained and used by modern frameworks
  • Better support in modern IDEs

closes #4140

@ggivo ggivo marked this pull request as ready for review April 7, 2025 18:43
@ggivo ggivo requested review from atakavci, uglide and tishun April 7, 2025 18:43
@ggivo ggivo changed the title Migrate to Junit5 Migrate test to JUnit5 Apr 7, 2025
@ggivo ggivo requested a review from Copilot April 7, 2025 18:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 312 out of 313 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • pom.xml: Language not supported

Copy link
Contributor

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggivo ggivo merged commit 1d1b268 into redis:master Apr 9, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate test to JUnit5
2 participants