Skip to content

Conversation

AlBlanc
Copy link
Contributor

@AlBlanc AlBlanc commented Aug 22, 2025

No description provided.

@PavelPashov
Copy link
Contributor

Hey @AlBlanc, thank you for the contribution! Could you confirm if the changes in docs folder are necessary? Additionally, please open a PR in the commands repo, similar to this one.

@AlBlanc
Copy link
Contributor Author

AlBlanc commented Aug 26, 2025

Hello @PavelPashov :)

About the change in docs... I just rebuilt the doc with the new command, I guess it is necessary, let me know your thoughts.

Yes, I forgot to make a PR to the commands repo. But I guess you wanted to mention this one ? The one you linked just have an empty commit.

@AlBlanc
Copy link
Contributor Author

AlBlanc commented Aug 26, 2025

Here is the PR

@PavelPashov
Copy link
Contributor

Hello @PavelPashov :)

About the change in docs... I just rebuilt the doc with the new command, I guess it is necessary, let me know your thoughts.

Yes, I forgot to make a PR to the commands repo. But I guess you wanted to mention this one ? The one you linked just have an empty commit.

Yes, thank you!

Copy link
Contributor

@PavelPashov PavelPashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes related to the docs directory, as the documentation is automatically generated as part of the release workflow.

In addition, it would be great to include functional tests for the command, similar to the ones provided here.

@PavelPashov
Copy link
Contributor

Hey, @AlBlanc, we're planning a minor release soon, can you check my comments and let me know if we should try to include this

@PavelPashov PavelPashov force-pushed the feature/xdelex branch 2 times, most recently from d86ce2f to c811296 Compare September 15, 2025 07:34
Co-authored-by: DEFLANDRE ALBAN <[email protected]>
Copy link

@nkaradzhov nkaradzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@PavelPashov PavelPashov merged commit 7be3c8d into redis:main Sep 23, 2025
36 of 42 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 23, 2025
# [5.8.0](v5.7.0...v5.8.0) (2025-09-23)

### Bug Fixes

* **ssubscribe:** re-subscribe sharded pubsub channels individually on ready ([#2012](#2012)) ([55a410f](55a410f))

### Features

* add more xtrim method overloads and tests ([#2010](#2010)) ([8a3e052](8a3e052))
* implement proper hpexpire command signatures and tests ([#2006](#2006)) ([95e80af](95e80af))
* **stream:** Add XDELEX command ([#2003](#2003)) ([7be3c8d](7be3c8d))
* support client setinfo ([#2011](#2011)) ([a5d808b](a5d808b))
Copy link

🎉 This PR is included in version 5.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants