Fix race condition in clusterNodes.Addrs() #3219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve a race condition in the clusterNodes.Addrs() method. Previously, the method returned a reference to a string slice, creating the potential for concurrent reads by the caller while the slice was being modified by the garbage collection process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a Race Condition in clusterNodes.Addrs() Method.
The clusterNodes.Addrs() method previously returned a reference to a string slice, which introduced the potential for concurrent read operations by callers while the slice was being modified, potentially leading to undefined behavior. This race condition could occur during GC or other operations affecting the slice.
Fix: Updated the clusterNodes.Addrs() method to create and return a copy of the original addrs slice. By ensuring that callers receive an independent copy, we eliminate the possibility of concurrent access issues.
Fixes #3218