Feature/active active autoscaling #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 15 out of 22 changed files in this pull request and generated 1 comment.
Files not reviewed (7)
- active-active-terraform/.terraform.lock.hcl: Language not supported
- active-active-terraform/terraform.tfvars.example: Language not supported
- active-active-terraform/variables.tf: Language not supported
- redeploy-active-active.sh: Language not supported
- standalone-terraform/.terraform.lock.hcl: Language not supported
- standalone-terraform/terraform.tfvars.example: Language not supported
- standalone-terraform/variables.tf: Language not supported
Comments suppressed due to low confidence (2)
autoscaler/redis-cloud-autoscaler/src/main/java/com/redis/autoscaler/poller/PrometheusExtrasPoller.java:55
- [nitpick] Consider checking not only if db.getCrdbDatabases() is null but also if the returned array is empty to avoid potential IndexOutOfBounds exceptions when accessing its first element.
if(db.getCrdbDatabases() == null){
autoscaler/redis-cloud-autoscaler/src/main/java/com/redis/autoscaler/metrics/PrometheusMetrics.java:28
- [nitpick] Since 'configuredThroughput.put(dbId, new AtomicLong(throughput));' is called before this null check, consider moving the null check before updating the map to prevent potential NullPointerExceptions.
if(dbId == null || instance == null){
...edis-cloud-autoscaler/src/test/java/com/redis/autoscaler/RedisCloudDatabaseServiceTests.java
Outdated
Show resolved
Hide resolved
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making some adaptions to allow autoscaling to work with Active-Active databases