Pts #42
Open
Pts #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvalinrh
requested changes
Oct 10, 2024
# Conflicts: # phoronix/run_phoronix.sh
|
I think what we want to do, to simplify the code is to create test option file, with override ability at the command line for the test. So something like this File sub test name: If no overrides are given, we will use the options for the test. We can mandate that the order of the options follow that of the sub test request for input. If an over ride is desired, then something like this --test_option_override test name:option_name:value,................. |
sousinha97
added
the
pr_review
dvalinrh
requested changes
Mar 18, 2025
| @@ -109,6 +115,7 @@ if [ ! -d "test_tools" ]; then | |||
| git clone $tools_git test_tools | |||
| if [ $? -ne 0 ]; then | |||
| error_out "Error pulling git $tools_git" 1 | |||
| exit | |||
There was a problem hiding this comment.
Not required, error out exits
| if [ $move_back -eq 1 ]; then | ||
| mv /tmp/perf $move_this | ||
| fi | ||
| exit |
| *) | ||
| echo option not found $1 | ||
| usage | ||
| exit |
There was a problem hiding this comment.
Not needed usage exits out with rtc 1
| ;; | ||
| --usage) | ||
| usage | ||
| exit |
There was a problem hiding this comment.
Not needed, usage exits with rtc 1.
| if [[ -n "${options[$key]}" ]]; then | ||
| options[$key]=$values | ||
| else | ||
| echo "Unknown option: $key" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.