Support local ocp inventory file in override #634
Conversation
providing an absolute path to ocpinventory json file for modified inventory data
|
Hi @sarahbx. Thanks for your PR. I'm waiting for a redhat-performance member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
There was a problem hiding this comment.
Lets get the documentation updated for this as well - https://github.com/redhat-performance/jetlag/blob/main/docs/tips-and-vars.md#override-lab-ocpinventory-json-file
| set_fact: | ||
| ocpinventory: | ||
| json: "{{ lookup('file', ocp_inventory_url) }}" | ||
| when: ocp_inventory_url | regex_search('^/') |
There was a problem hiding this comment.
What if change the when statement to:
when: "'skipped' in ocpinventory"so that you can just place the override inventory file ansible directory and it will be looked up. This would work with both absolute paths and placing the inventory in ansible directory.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @sarahbx did you think you will be able to address the docs request? |
providing an absolute path to ocpinventory json file for modified inventory data