Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fab): add new mountpoints support for providers and listeners (fixed CI issue) #2312

Merged

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Feb 4, 2025

Same as #2199 but rebased andresolve yarn.lock merge conflict by just run it again.

After rebasing the PR it was required to update the backstage/cli devDependency version in dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-global-header/package.json to the same version that all plugins use.

/cc @debsmita1 @ciiay

@openshift-ci openshift-ci bot requested review from ciiay and debsmita1 February 4, 2025 13:23
@christoph-jerolimov christoph-jerolimov changed the title feat(fab): add new mountpoints support for providers and listeners (fixed yarn.lock) feat(fab): add new mountpoints support for providers and listeners (fixed CI issue) Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Copy link
Member

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you!

Copy link

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ciiay
Once this PR has been reviewed and has the lgtm label, please ask for approval from christoph-jerolimov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christoph-jerolimov christoph-jerolimov merged commit ef10f2e into redhat-developer:main Feb 4, 2025
11 of 12 checks passed
@christoph-jerolimov christoph-jerolimov deleted the dynamic-fab branch February 4, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants