Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(application-provider-test): add CrashProvider and exports now two seperate context providers and cards #370

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Jan 31, 2025

Hey, I just made a Pull Request!

Improved test plugin two test the RHDH change with two providers. /cc @debsmita1 :)

I now also added a CrashProvider. It's not needed that this is handled in rhdh yet, but it's good to have a test component for that.

The link in the README depends on redhat-developer/rhdh#2199 and should work soon. :)

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation (just the README)
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Jan 31, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-application-provider-test workspaces/global-floating-action-button/plugins/application-provider-test patch v0.0.1

@christoph-jerolimov christoph-jerolimov changed the title docs(application-provider-test): export two seperate context providers and cards feat(application-provider-test): export two seperate context providers and cards Jan 31, 2025
@christoph-jerolimov christoph-jerolimov force-pushed the application-provider-test-update-test-components branch from f999e7e to 41a3969 Compare January 31, 2025 14:03
@christoph-jerolimov christoph-jerolimov changed the title feat(application-provider-test): export two seperate context providers and cards feat(application-provider-test): Add a new CrashProvider and exports now two seperate context providers and cards Jan 31, 2025
@christoph-jerolimov christoph-jerolimov force-pushed the application-provider-test-update-test-components branch from 41a3969 to 0f9906f Compare January 31, 2025 14:05
@christoph-jerolimov christoph-jerolimov changed the title feat(application-provider-test): Add a new CrashProvider and exports now two seperate context providers and cards feat(application-provider-test): add CrashProvider and exports now two seperate context providers and cards Jan 31, 2025
Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 31, 2025
@debsmita1 debsmita1 merged commit 4cdaedf into redhat-developer:main Jan 31, 2025
9 checks passed
@christoph-jerolimov christoph-jerolimov deleted the application-provider-test-update-test-components branch January 31, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants