Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fab): add application listener and provider test plugins #318

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Jan 24, 2025

Hey, I just made a Pull Request!

Resolves https://issues.redhat.com/browse/RHIDP-5691

This adds two new test plugins to test the application/listener and application/provider.

We might want to move them later into another workspace. I'll add this topic to the architecture call. That's the reason I called them application-listener-test and not fab-test. We might want to have that as well. But FAB components are mostly configuration so I'm not sure if that is needed.

These both plugins should be tested after they are released on npm together with redhat-developer/rhdh#2199

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Jan 24, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-application-listener-test workspaces/global-floating-action-button/plugins/application-listener-test patch v0.0.0
@red-hat-developer-hub/backstage-plugin-application-provider-test workspaces/global-floating-action-button/plugins/application-provider-test patch v0.0.0

@christoph-jerolimov christoph-jerolimov force-pushed the application-test-plugins branch 4 times, most recently from d187e51 to b1286fd Compare January 24, 2025 13:43
Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2025
@christoph-jerolimov christoph-jerolimov merged commit c5fd624 into redhat-developer:main Jan 27, 2025
10 checks passed
@christoph-jerolimov christoph-jerolimov deleted the application-test-plugins branch January 27, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants